Conversation
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr
commented
Dec 10, 2019
| import static org.mockito.Matchers.anyString; | ||
| //import static org.mockito.Matchers.anyLong; | ||
| //import static org.mockito.Matchers.anyObject; | ||
| //import static org.mockito.Matchers.anyString; |
Member
Author
There was a problem hiding this comment.
@Pearl1594 remove any dead code and commented code.
Member
Author
|
@Pearl1594 overall lgtm, I'll do a thorough review and tests tomorrow. The only outstanding issue is that of removing dead and commented code. |
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
Looks like squash merge changed the authorship I'll fix it manually on apache#3601 so @Pearl1594 gets commit in her name for her changes |
yadvr
pushed a commit
that referenced
this pull request
Dec 10, 2019
Fix unit tests by using newer mocking approaches, leniency and fixing xml/mocks. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
shwstppr
added a commit
that referenced
this pull request
Aug 16, 2021
From 4.9.3.0 to 4.10.0.0 storing of tags for storage pools was changed from cloud.storage_pool_details to cloud.storage_pool_tags. Up-port in #47 missed this and was using tag retrieval from the old table. https://github.com/apache/cloudstack/blob/4.10.0.0/setup/db/db/schema-4930to41000.sql#L139-L151 Unit tests replaced from https://github.com/apache/cloudstack/blob/4.12.0.0/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.